[jira] Commented: (MYFACES-183) FacesConfigurator should report where xml parsing errors occur

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (MYFACES-183) FacesConfigurator should report where xml parsing errors occur

sean schofield (JIRA)
    [ http://issues.apache.org/jira/browse/MYFACES-183?page=comments#action_12317427 ]

Mike Kienenberger commented on MYFACES-183:
-------------------------------------------

Yes, there's a line at debug level.   It'd be better for it to be issued at INFO level.   In my opinion, the temporary jar name should be output at debug level, and the real jar name should be output at INFO level.   End-user developers don't care about the internals of how MyFaces parses our jars, only that it does parse them.   "config jar:file:/D:/DOCUME~1/mlk/LOCALS~1/Temp/myfaces48297.jar" is meaningless to us, but "jsf-spring-2.7.1.jar" has meaning.

> FacesConfigurator should report where xml parsing errors occur
> --------------------------------------------------------------
>
>          Key: MYFACES-183
>          URL: http://issues.apache.org/jira/browse/MYFACES-183
>      Project: MyFaces
>         Type: Improvement
>     Versions: 1.0.9 beta
>     Reporter: Mike Kienenberger
>     Priority: Minor

>
> org.apache.myfaces.config.FacesConfigurator should report which resources it was parsing when it encounters an error.
> This could be done by wrapping the parsing exception with another more verbose exception.  Thus, something like
> MyApp ERROR [main 04-12 11:24:18] Digester: Parse Error at line 2 column 14: Document is invalid: no grammar found.
> org.xml.sax.SAXParseException: Document is invalid: no grammar found.
> becomes
> MyApp ERROR [main 04-12 11:24:18] FacesConfigurator : Error parsing jsf-spring-2.7.1.jar:faces-config.xml: Parse Error at line 2 column 14: Document is invalid: no grammar found.
> org.xml.sax.SAXParseException: Document is invalid: no grammar found.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira