[jira] [Commented] (TOBAGO-1721) Optimize HTML output when two renderer are involved

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[jira] [Commented] (TOBAGO-1721) Optimize HTML output when two renderer are involved

My Faces - Dev mailing list

    [ https://issues.apache.org/jira/browse/TOBAGO-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16028177#comment-16028177 ]

Hudson commented on TOBAGO-1721:

SUCCESS: Integrated in Jenkins build Tobago Trunk #895 (See [https://builds.apache.org/job/Tobago%20Trunk/895/])
TOBAGO-1721 Optimize HTML output when two renderer are involved
* fix dropdowns inside button groups (css class 'btn-group' was missing) (hnoeth: [http://svn.apache.org/viewvc/?view=rev&rev=1796602])
* (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/component/RendererTypes.java
* (add) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/ButtonInsideButtonsRenderer.java
* (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/ButtonsRenderer.java
* (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/ButtonTagDeclaration.java
* (add) tobago-trunk/tobago-example/tobago-example-demo/src/main/webapp/content/20-component/040-command/20-buttons/buttons.test.js
* (edit) tobago-trunk/tobago-example/tobago-example-demo/src/test/java/org/apache/myfaces/tobago/example/demo/QUnitTests.java

> Optimize HTML output when two renderer are involved
> ---------------------------------------------------
>                 Key: TOBAGO-1721
>                 URL: https://issues.apache.org/jira/browse/TOBAGO-1721
>             Project: MyFaces Tobago
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.0.3
>            Reporter: Henning Noeth
>            Assignee: Henning Noeth
> A renderer produce HTML code without consider the environment.
> For example:
> The InRenderer always generate a <span/> around children.
> If a button has children, the ButtonRenderer always generate a <span/> element around the button and its children.
> So if a <tc:button> is inside a <tc:in>, two <span/> elements would be generated.
> In this case, the renderer should work together, to only generate one <span> element.
> The generated code is more compact.
> It's more the way of bootstrap.
> And because of that, there are less problems to solve with CSS.

This message was sent by Atlassian JIRA